make ml_matches
return nothing
when there are too many matches
#44478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #44448 (comment).
Previously
ml_matches
(and its dependent utilities like_methods_by_ftype
)returned
false
for cases when there are too many matching method, butits consumer like
findall(::Type, ::InternalMethodTable)
usually handlessuch case as
missing
. This commit does a refactor so that they all usethe more consistent value
nothing
for representing that case.