Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RemoveAddrspaces] make MappedTypes non-static #44453

Merged
merged 2 commits into from
Mar 6, 2022
Merged

[RemoveAddrspaces] make MappedTypes non-static #44453

merged 2 commits into from
Mar 6, 2022

Conversation

vchuravy
Copy link
Sponsor Member

@vchuravy vchuravy commented Mar 4, 2022

IIUC correctly static means that the member variable will be shared across all instances.
If you use this with multiple context, some of them having short-live times, you can get into
the situation where we believe to have seen the pointer already.

https://en.cppreference.com/w/cpp/language/static

@vchuravy vchuravy added backport 1.6 Change should be backported to release-1.6 backport 1.7 backport 1.8 Change should be backported to release-1.8 kind:bug Indicates an unexpected problem or unintended behavior labels Mar 4, 2022
@vchuravy vchuravy requested a review from maleadt March 4, 2022 16:56
maleadt
maleadt approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. LGTM!

@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Mar 4, 2022
@vchuravy vchuravy merged commit 610fc20 into master Mar 6, 2022
@vchuravy vchuravy deleted the vc/non_static branch March 6, 2022 05:02
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Mar 6, 2022
KristofferC pushed a commit that referenced this pull request Mar 7, 2022
@vchuravy @KristofferC
[RemoveAddrspaces] make MappedTypes non-static (#44453)
5b14e07 
(cherry picked from commit 610fc20)
@KristofferC KristofferC mentioned this pull request Mar 7, 2022
Merged
47 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Mar 15, 2022
KristofferC pushed a commit that referenced this pull request Mar 15, 2022
@vchuravy
[RemoveAddrspaces] make MappedTypes non-static (#44453)
ae03b91 
(cherry picked from commit 610fc20)
@KristofferC KristofferC mentioned this pull request Mar 15, 2022
Merged
50 tasks
KristofferC pushed a commit that referenced this pull request Mar 16, 2022
@vchuravy
[RemoveAddrspaces] make MappedTypes non-static (#44453)
0494f96 
(cherry picked from commit 610fc20)
KristofferC pushed a commit that referenced this pull request Apr 19, 2022
@vchuravy @KristofferC
[RemoveAddrspaces] make MappedTypes non-static (#44453)
6918fc4 
(cherry picked from commit 610fc20)
@KristofferC KristofferC mentioned this pull request Apr 19, 2022
Merged
40 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label May 16, 2022
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vchuravy @staticfloat
[RemoveAddrspaces] make MappedTypes non-static (#44453)
8dfa55e 
(cherry picked from commit 610fc20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

Assignees
No one assigned
Labels
kind:bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vchuravy @maleadt @vtjnash @KristofferC @DilumAluthge