Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pidfile to FileWatching #44367

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

IanButterworth
Copy link
Sponsor Member

Continuation of #42471 (a force push meant that couldn't be re-opened)

This bring's @vtjnash's https://github.com/vtjnash/Pidfile.jl into FileWatching

I did a very light touch port here. The only changes to the pidfile source were to fix imports/exports.

Closes #42571

Co-Authored-By: Jameson Nash <[email protected]>
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggested cleanup for VERSION checks

stdlib/FileWatching/src/pidfile.jl Outdated Show resolved Hide resolved
stdlib/FileWatching/src/pidfile.jl Outdated Show resolved Hide resolved
stdlib/FileWatching/src/pidfile.jl Outdated Show resolved Hide resolved
stdlib/FileWatching/src/pidfile.jl Outdated Show resolved Hide resolved
stdlib/FileWatching/src/pidfile.jl Outdated Show resolved Hide resolved
stdlib/FileWatching/test/pidfile.jl Outdated Show resolved Hide resolved
stdlib/FileWatching/test/pidfile.jl Outdated Show resolved Hide resolved
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 28, 2022
@DilumAluthge DilumAluthge merged commit d07a913 into JuliaLang:master Feb 28, 2022
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 28, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
Co-authored-by: Jameson Nash <[email protected]>

Co-authored-by: Jameson Nash <[email protected]>
@IanButterworth IanButterworth deleted the ib/add_pidfile branch March 4, 2022 04:37
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Co-authored-by: Jameson Nash <[email protected]>

Co-authored-by: Jameson Nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants