Redo: Add profiling of already running tasks via SIGINFO/SIGUSR1 #44185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This appears to have fixed the issue, but CI is behind |
vtjnash
reviewed
Feb 15, 2022
| iob = IOBuffer() | ||
| ioc = IOContext(IOContext(iob, stdout), :displaysize=>displaysize(stdout)) | ||
| print(ioc, groupby = [:thread, :task]) | ||
| Base.print(stdout, String(resize!(iob.data, iob.size))) |
There was a problem hiding this comment.
I am not sure where you found the privacy-violating resize! accessor, but we have take! for this:
Base.print(stdout, String(take!(iob.data)))
There was a problem hiding this comment.
Great question. I usually do take! I'll try to find where I copied that from.
There was a problem hiding this comment.
I can't find where I got it from.. weird.
Applying suggestions #44199
vtjnash
reviewed
Feb 15, 2022
| static double profile_autostop_time = -1.0; | ||
| static double profile_peek_duration = 1.0; // seconds | ||
|
|
||
| double jl_get_profile_peek_duration(void) { |
There was a problem hiding this comment.
style nit: functions start with { on the next line
Suggested change
| double jl_get_profile_peek_duration(void) { | |
| double jl_get_profile_peek_duration(void) | |
| { |
vtjnash
reviewed
Feb 15, 2022
| } | ||
| void jl_set_profile_peek_duration(double t) { | ||
| profile_peek_duration = t; | ||
| return; |
There was a problem hiding this comment.
style nit: return is not needed
Suggested change
| return; |
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
…iaLang#44185) * Redo: Add profiling of already running tasks via SIGINFO/SIGUSR1 * fix precompile script
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…iaLang#44185) * Redo: Add profiling of already running tasks via SIGINFO/SIGUSR1 * fix precompile script
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…iaLang#44185) * Redo: Add profiling of already running tasks via SIGINFO/SIGUSR1 * fix precompile script
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #43179 (which has been reverted)
I overlooked buildkite build hangs.
It turns out the precompile script revised during review was bad but for some reason it didn't error on the buildbots, and may have caused the hangs on buildkite. TBC.