use specialized code when compiling opaque closure expressions #44176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invoke specialization when an OC is created at run time
vtjnash
reviewed
Feb 15, 2022
| closure_decls.specFunctionObject; | ||
| if (GlobalValue *V = jl_Module->getNamedValue(fname)) { | ||
| F = cast<Function>(V); | ||
| } else { |
There was a problem hiding this comment.
style nit: I don't know why we use this convention, but we usually do
Suggested change
| } else { | |
| } | |
| else { |
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
…Lang#44176) invoke specialization when an OC is created at run time
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…Lang#44176) invoke specialization when an OC is created at run time
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…Lang#44176) invoke specialization when an OC is created at run time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry #43320