Profile.Allocs: Add task and timestamp (take 2) #44162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsamaroo
force-pushed
the
jps/alloc-ns-ct
branch
from
f0d076f
to
6463613
Compare
|
@DilumAluthge analyzegc is now passing, and the |
vtjnash
added
the
status:merge me
DilumAluthge
removed
the
status:merge me
NHDaly
reviewed
Feb 18, 2022
Comment on lines
+23
to
+24
| jl_task_t *task; | ||
| uint64_t timestamp; |
There was a problem hiding this comment.
It's nit-picking, but I would appreciate if you either stored the task as a void*, or even a size_t, and/or added a comment here indicating that this pointer is not rooted, and therefore might not even be live anymore, and you should never try to load it.
Can you send a tiny follow up to address this? :) Thanks!
I also like matching the julia and C structs as much as possible, so void* in both or size_t in both makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #44055 for details and discussion