Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few missing effects taints #44125

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Add a few missing effects taints #44125

merged 1 commit into from
Feb 11, 2022

Conversation

Keno
Copy link
Member

@Keno Keno commented Feb 11, 2022

Closes #44123

Should fix Downloads test (it decided Downloads' easy_hook
didn't do anything and accidentally deleted it).

Should fix Downloads test (it decided Downloads' easy_hook
didn't do anything and accidentally deleted it).
@DilumAluthge
Copy link
Member

If CI passes, I assume this closes #44123?

@Keno
Copy link
Member Author

Keno commented Feb 11, 2022

yes

@DilumAluthge DilumAluthge added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 11, 2022
@Keno Keno merged commit a557536 into master Feb 11, 2022
@Keno Keno deleted the kf/fixdownloads branch February 11, 2022 17:51
@DilumAluthge DilumAluthge added kind:bugfix This change fixes an existing bug and removed status:merge me PR is reviewed. Merge when all tests are passing labels Feb 11, 2022
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
Should fix Downloads test (it decided Downloads' easy_hook
didn't do anything and accidentally deleted it).
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
Should fix Downloads test (it decided Downloads' easy_hook
didn't do anything and accidentally deleted it).
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Should fix Downloads test (it decided Downloads' easy_hook
didn't do anything and accidentally deleted it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bugfix This change fixes an existing bug kind:embarrassing-bugfix Whoops!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants