Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inlining: use ConstResult if available #44101

Merged
merged 1 commit into from
Feb 10, 2022
Merged

inlining: use ConstResult if available #44101

merged 1 commit into from
Feb 10, 2022

Conversation

aviatesk
Copy link
Member

A minor follow up PR for #43852.

@aviatesk aviatesk requested a review from Keno February 10, 2022 00:51
Keno
Keno approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to make sure to have tests for the various cases.

@aviatesk aviatesk added the merge me PR is reviewed. Merge when all tests are passing label Feb 10, 2022
@aviatesk
Copy link
Member Author

aviatesk commented Feb 10, 2022 •
edited
Loading

@Keno are you okay with this change? 17da4d4

@Keno
Copy link
Member

Keno commented Feb 10, 2022

@Keno are you okay with this change? 17da4d4

fine by me

@aviatesk
inference: follow up #43852
03c2970 
This commit consists of minor follow up tweaks for #43852:
- inlining: use `ConstResult` if available
- refactor tests
- simplify `CodeInstance` constructor signature
- tweak `concrete_eval_const_proven_total_or_error` signature for JET integration
@aviatesk aviatesk merged commit fed4544 into master Feb 10, 2022
@aviatesk aviatesk deleted the avi/constresult branch February 10, 2022 05:58
DilumAluthge added a commit that referenced this pull request Feb 11, 2022
@DilumAluthge
Revert "inference: follow up #43852 (#44101)"
d255809 
This reverts commit fed4544.
@DilumAluthge DilumAluthge mentioned this pull request Feb 11, 2022
Closed
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Feb 11, 2022
DilumAluthge added a commit that referenced this pull request Feb 11, 2022
@DilumAluthge
Revert "inference: follow up #43852 (#44101)"
8c26aff 
This reverts commit fed4544.
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
@aviatesk @antoine-levitt
inference: follow up JuliaLang#43852 (JuliaLang#44101)
4b623d1 
This commit consists of minor follow up tweaks for JuliaLang#43852:
- inlining: use `ConstResult` if available
- refactor tests
- simplify `CodeInstance` constructor signature
- tweak `concrete_eval_const_proven_total_or_error` signature for JET integration
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@aviatesk @LilithHafner
inference: follow up JuliaLang#43852 (JuliaLang#44101)
41877bb 
This commit consists of minor follow up tweaks for JuliaLang#43852:
- inlining: use `ConstResult` if available
- refactor tests
- simplify `CodeInstance` constructor signature
- tweak `concrete_eval_const_proven_total_or_error` signature for JET integration
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@aviatesk @LilithHafner
inference: follow up JuliaLang#43852 (JuliaLang#44101)
7ef836f 
This commit consists of minor follow up tweaks for JuliaLang#43852:
- inlining: use `ConstResult` if available
- refactor tests
- simplify `CodeInstance` constructor signature
- tweak `concrete_eval_const_proven_total_or_error` signature for JET integration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aviatesk @Keno @DilumAluthge