Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement promote for BitArray #44096

Merged
merged 2 commits into from
Mar 2, 2022
Merged

implement promote for BitArray #44096

merged 2 commits into from
Mar 2, 2022

Commits on Mar 1, 2022

  1. fix reduced_indices type bug (#44096) 

    The result is type-asserted to be equal to the input, so we need to use
a non-promoting function.
    @vtjnash
    vtjnash committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    c6e3146 View commit details
    Browse the repository at this point in the history

  2. implement promote for BitArray (#44096) 

    Defines a fallback promote_result for any AbstractArray, for the case
when specific promote_rules are not defined for the specific array type.

Add a few good promote_rules too.

Fix #43551

Co-authored-by: Jakob Sachs <[email protected]>
    @vtjnash @JakobSachs
    vtjnash and JakobSachs committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    5cac5b9 View commit details
    Browse the repository at this point in the history