Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option for TestLogger to not respect maxlog #44085

Merged
merged 2 commits into from
Feb 9, 2022
Merged

Provide option for TestLogger to not respect maxlog #44085

merged 2 commits into from
Feb 9, 2022

Conversation

ericphanson
Copy link
Contributor

@ericphanson ericphanson commented Feb 8, 2022 •
edited
Loading

As proposed in #44079 (comment). Closes #44079

@ericphanson ericphanson mentioned this pull request Feb 9, 2022
Closed
fredrikekre
fredrikekre approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you need to rebase to include #44081 to fix CI.

@fredrikekre fredrikekre added logging The logging framework test This change adds or pertains to unit tests labels Feb 9, 2022
@vtjnash vtjnash added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 9, 2022
@fredrikekre fredrikekre merged commit 93a5f69 into JuliaLang:master Feb 9, 2022
@ericphanson ericphanson deleted the eph/optional-maxlog branch February 9, 2022 23:02
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 9, 2022
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
@ericphanson @antoine-levitt
Test.TestLogger: add respect_maxlog option (JuliaLang#44085)
523ec6b
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@ericphanson @LilithHafner
Test.TestLogger: add respect_maxlog option (JuliaLang#44085)
61ddb97
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@ericphanson @LilithHafner
Test.TestLogger: add respect_maxlog option (JuliaLang#44085)
fb9aa5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
logging The logging framework test This change adds or pertains to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericphanson @vtjnash @fredrikekre @DilumAluthge