Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize real matrix * complex matrix by using real matmul #44074

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Optimize real matrix * complex matrix by using real matmul #44074

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98791b1
Optimize real matrix * complex matrix by using real matmul
jishnub Feb 8, 2022
3364366
Broadcast Complex instead of +
jishnub Feb 8, 2022
84375b2
reduce allocations
jishnub Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimize real matrix * complex matrix by using real matmul
  • Loading branch information
@jishnub
jishnub committed Feb 8, 2022
commit 98791b1fde6e54d6ba2192b65e9593db362bf262
8 changes: 2 additions & 6 deletions stdlib/LinearAlgebra/src/matmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,12 +174,8 @@ function (*)(A::AdjOrTransStridedMat{<:BlasComplex}, B::StridedMaybeAdjOrTransMa
wrapperop(B)(convert(AbstractArray{real(TS)}, _parent(B))))
end
# the following case doesn't seem to benefit from the translation A*B = (B' * A')'
function (*)(A::StridedMatrix{<:BlasReal}, B::StridedMatrix{<:BlasComplex})
TS = promote_type(eltype(A), eltype(B))
mul!(similar(B, TS, (size(A, 1), size(B, 2))),
convert(AbstractArray{TS}, A),
convert(AbstractArray{TS}, B))
end
(*)(A::StridedMatrix{<:BlasReal}, B::StridedMatrix{<:BlasComplex}) =
(A * real(B)) .+ im .* (A * imag(B))
jishnub marked this conversation as resolved.
Show resolved Hide resolved
(*)(A::AdjOrTransStridedMat{<:BlasReal}, B::StridedMatrix{<:BlasComplex}) = copy(transpose(transpose(B) * parent(A)))
(*)(A::StridedMaybeAdjOrTransMat{<:BlasReal}, B::AdjOrTransStridedMat{<:BlasComplex}) = copy(wrapperop(B)(parent(B) * transpose(A)))

Expand Down