Add note about reduce([hv]cat, x) optimization to docstrings for hcat and vcat
#44049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hcat` and `vcat`.
Moelf
approved these changes
Feb 9, 2022
|
This seems like it's probably ready to be merged before the 1.8 deadline. It's only a docstring addition (no deletions), with a performance note (nothing that would change the declared API of course). |
|
If anyone is listening, this should be good to merge before the 1.8 deadline tomorrow. (I don't have merge rights.) |
|
this is not a feature, can be merged anytime before release |
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
Feb 17, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
reduce([hv]cat, x)optimizations are not very discoverable, because they don't seem to be mentioned anywhere in the manual, performance tips, or the docstrings, so I've added a note aboutreduce([hv]cat, x)to the docstrings forhcatandvcat.