Inferrability: eliminate more Core.Box #44029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
reviewed
Feb 3, 2022
These stem from julia#15276, i.e., https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-captured They were identified by scanning all compiled MethodInstances with hasbox in the newly-released MethodAnalysis 0.4.5. Core.Box often causes "follow-on" inference problems, but for these cases there were relatively few, which may be why these didn't show up earlier during the Great Invalidation Hunt. Still, there doesn't seem to be any particular reason not to fix them. This doesn't eliminate all Core.Box cases from Base, but only a handful remain. The most common remaining case stems from inner functions calling themselves.
|
I threw in a couple of annotations that eliminate a very small number of Test invalidations as well. (The whole module is |
vtjnash
reviewed
Feb 3, 2022
vtjnash
approved these changes
Feb 3, 2022
Co-authored-by: Jameson Nash <[email protected]>
aviatesk
approved these changes
Feb 4, 2022
vtjnash
added
the
status:merge me
DilumAluthge
removed
the
status:merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
These stem from julia#15276, i.e., https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-captured They were identified by scanning all compiled MethodInstances with hasbox in the newly-released MethodAnalysis 0.4.5. Core.Box often causes "follow-on" inference problems, but for these cases there were relatively few, which may be why these didn't show up earlier during the Great Invalidation Hunt. Still, there doesn't seem to be any particular reason not to fix them. This doesn't eliminate all Core.Box cases from Base, but only a handful remain. The most common remaining case stems from inner functions calling themselves. It also prevents a couple of Test invalidations Co-authored-by: Jameson Nash <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
These stem from julia#15276, i.e., https://docs.julialang.org/en/v1/manual/performance-tips/#man-performance-captured They were identified by scanning all compiled MethodInstances with hasbox in the newly-released MethodAnalysis 0.4.5. Core.Box often causes "follow-on" inference problems, but for these cases there were relatively few, which may be why these didn't show up earlier during the Great Invalidation Hunt. Still, there doesn't seem to be any particular reason not to fix them. This doesn't eliminate all Core.Box cases from Base, but only a handful remain. The most common remaining case stems from inner functions calling themselves. It also prevents a couple of Test invalidations Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These stem from #15276, i.e., captured variables.
They were identified by scanning all compiled MethodInstances with
hasboxin the newly-released MethodAnalysis 0.4.5.Core.Boxoften causes "follow-on" inference problems,but for these cases there were relatively few, which may be why
these didn't show up earlier during the Great Invalidation Hunt.
Still, there doesn't seem to be any particular reason not to fix them.
This doesn't eliminate all
Core.Boxcases from Base, but only ahandful remain. The most common remaining case stems from inner
functions calling themselves.