Fix detection of LIBGFORTRAN_VERSION #44026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
At the moment we have
sandbox:${WORKSPACE}/julia # cc --version
x86_64-linux-gnu-gcc (GCC) 7.1.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
sandbox:${WORKSPACE}/julia # make print-BB_TRIPLET_LIBGFORTRAN
BB_TRIPLET_LIBGFORTRAN=x86_64-linux-gnu-libgfortran5which is wrong, because GCC 7 corresponds to libgfortran 4, instead with this PR:
sandbox:${WORKSPACE}/julia # make print-BB_TRIPLET_LIBGFORTRAN
BB_TRIPLET_LIBGFORTRAN=x86_64-linux-gnu-libgfortran4as expected
vchuravy
approved these changes
Feb 3, 2022
KristofferC
pushed a commit
that referenced
this pull request
Feb 15, 2022
(cherry picked from commit 1edafa0)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty string
""was passed as the second arg tonormalize_triplet.pydue to a typo, which makes the script pick gfortran5, resulting in an errorlater when using e.g. GCC 7.5.0.
Introduced in 6b91bbb, so should only be backported to 1.7.x