Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Diagonal \ StaticArray #44018

Merged
merged 7 commits into from
Feb 8, 2022
Merged

Fix Diagonal \ StaticArray #44018

merged 7 commits into from
Feb 8, 2022

Conversation

dkarrasch
Copy link
Member

This restores the old behavior, but keeps the singularity check which was the only reason why this method directed to 3-arg ldiv!.

@dkarrasch
Copy link
Member Author

@nanosoldier runtests(["StaticArrays"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected. A full report can be found here.

@dkarrasch dkarrasch added kind:bugfix This change fixes an existing bug domain:linear algebra Linear algebra labels Feb 3, 2022
@dkarrasch
Copy link
Member Author

@nanosoldier runtests(["StaticArrays"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected. A full report can be found here.

@dkarrasch dkarrasch closed this Feb 7, 2022
@dkarrasch dkarrasch reopened this Feb 7, 2022
@dkarrasch dkarrasch merged commit c84896c into master Feb 8, 2022
@dkarrasch dkarrasch deleted the dk/diagfix branch February 8, 2022 09:09
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request Feb 17, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:linear algebra Linear algebra kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants