Fix asan for jl_precompile_toplevel_module #43885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's now a different asan error, but it seems to be unrelated and present before these changes were merged (e.g., https://buildkite.com/julialang/julia-master/builds/7773#773891f2-27cf-4148-b26c-b50d3374883d). |
|
Since this passed everything and it was added to exports only to solve a linker error that seems to not be real (or at least, not related to the changes in #43793), I'm going to merge so it doesn't affect CI for others. |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
PR JuliaLang#43793 passed the buildkite test but the logs for JuliaLang#43881 show an address sanitzer failure. Removing jl_precompile_toplevel_module from jl_exported_data.inc fixes the error. For good measure, set it to NULL at the point of definition, even though it gets nulled during initialization.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
PR JuliaLang#43793 passed the buildkite test but the logs for JuliaLang#43881 show an address sanitzer failure. Removing jl_precompile_toplevel_module from jl_exported_data.inc fixes the error. For good measure, set it to NULL at the point of definition, even though it gets nulled during initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #43793 passed the buildkite test but the logs for #43881 show an
address sanitzer failure. Removing
jl_precompile_toplevel_modulefromjl_exported_data.incfixes the error. For good measure, set it toNULLat the point of definition, even though it gets nulled during
initialization.