[REPLCompletions] improved handling of completions #43865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f92dbe2
to
31ce47d
Compare
vtjnash
commented
Jan 24, 2022
Caused `foo).<tab>` to crash, for example.
Now we can fully handle all type signatures in ml_matches and give back the complete list (though potentially slowly).
- Restrict method completion to ignore strictly less specific ones - Fix various lookup bugs - Improve slurping of final expression Inspired by #43572 Co-authored-by: Lionel Zoubritzky <[email protected]>
31ce47d
to
d7e3d99
Compare
|
(reviewed in-person with Jeff) |
aviatesk
added a commit
that referenced
this pull request
Jan 27, 2022
…ompletion` `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc.
aviatesk
added a commit
that referenced
this pull request
Jan 27, 2022
…ompletion` `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc. Co-Authored-By: Jameson Nash <[email protected]>
aviatesk
added a commit
that referenced
this pull request
Jan 28, 2022
…ompletion` (#43946) `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc.
aviatesk
added a commit
to JunoLab/FuzzyCompletions.jl
that referenced
this pull request
Jan 28, 2022
update to JuliaLang/julia#43865
aviatesk
added a commit
to JunoLab/FuzzyCompletions.jl
that referenced
this pull request
Jan 28, 2022
update to JuliaLang/julia#43865
This was referenced Jan 31, 2022
This was referenced Feb 1, 2022
Closed
Closed
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
… `MethodCompletion` (JuliaLang#43946) `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
… `MethodCompletion` (JuliaLang#43946) `MethodCompletion.tt` is being used by an external consumer like Juno or VSCode's runtime completion features to get additional information like return type, etc.
👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by (replaces) #43572 @Liozou
This tries to improve the REPLCompletions method lookup, replacing a custom implementation with our standard one. It also seeks to improve and fix a variety of other outstanding deficiencies that were previously unhandled.