Remove jl_LLVMContext #43827
Merged
Remove jl_LLVMContext #43827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
reviewed
Jan 16, 2022
vtjnash
reviewed
Jan 21, 2022
vtjnash
reviewed
Jan 28, 2022
eb93fe6
to
c316452
Compare
vchuravy
approved these changes
Jan 28, 2022
fa7f423
to
d4e4968
Compare
d4e4968
to
9676c87
Compare
vchuravy
reviewed
Feb 20, 2022
|
|
||
| extern "C" JL_DLLEXPORT | ||
| LLVMContextRef jl_get_ee_context_impl(void) { | ||
| return wrap(jl_ExecutionEngine->getContext().getContext()); |
There was a problem hiding this comment.
So technically this is wrong, since you return the underlying context without first locking the TSCtx.
There was a problem hiding this comment.
I've added this as a small hack to get @code_llvm working since creating a new context is still causing some issues in codegen that I haven't tracked down yet; I intend to remove this method and thus the locking issue as soon as multiple contexts can get through codegen without issue. Since right now the context isn't used except under the codegen lock, we should temporarily be safe until that other issue is resolved.
This was referenced Feb 24, 2022
|
🎉 |
staticfloat
pushed a commit
to JuliaCI/julia-buildkite-testing
that referenced
this pull request
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the removal plan from #43791