move SparseArrays to the external repo https://github.com/JuliaLang/SparseArrays.jl #43813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
requested review from
staticfloat,
ViralBShah and
dkarrasch
and removed request for
staticfloat
dkarrasch
approved these changes
Jan 14, 2022
dkarrasch
added
domain:arrays:sparse
|
Merged JuliaSparse/SparseArrays.jl#7 and updated the SHA here. Will try merge somewhat quickly so that conflicts doesn't occur. |
|
Do we want a NEWS entry? |
ViralBShah
approved these changes
Jan 14, 2022
|
Sounds like a good idea, I'll add one. |
|
Wish I could give this PR a posthumous approval! |
Are you referring to https://github.com/JuliaLang/BumpStdlibs.jl? BumpStdlibs.jl won't bump the checksums every time you merge a PR to |
N5N3
pushed a commit
to N5N3/julia
that referenced
this pull request
Jan 24, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it uses the last commit in JuliaSparse/SparseArrays.jl#7. That should be merged and the SHA updated when it is.
There are some tests that loads SparseArrays:
Random/test/runtests.jlabstractarray.jlambiguous.jlarrayops.jlcore.jlhashing.jlshow.jlThese tests should migrate to the SparseArray repo, but that can be done after this PR is done.
@dkarrasch, @ViralBShah, I think we should try not to merge anything to SparseArrays in the Julia repo until this PR is merged.