Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit references to jl_data_layout #43756

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

pchintalapudi
Copy link
Member

This is another PR in the collection developing to reduce dependencies on global codegen variables.

@pchintalapudi pchintalapudi added compiler:codegen Generation of LLVM IR and native code kind:excision Removal of code from Base or the repository labels Jan 11, 2022
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth writing this as jl_Module-> getDataLayout() though, for concision?

@pchintalapudi pchintalapudi added the status:merge me PR is reviewed. Merge when all tests are passing label Jan 12, 2022
@vchuravy vchuravy merged commit 29ea1fe into JuliaLang:master Jan 12, 2022
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Jan 14, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@pchintalapudi pchintalapudi deleted the pc/fold-datalayout branch March 6, 2022 22:00
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code kind:excision Removal of code from Base or the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants