Remove global basic pointer types #43754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchintalapudi
added
compiler:codegen
9 tasks
pchintalapudi
force-pushed
the
pc/no-pointer-types
branch
2 times, most recently
from
132aee6
to
6784d8f
Compare
pchintalapudi
force-pushed
the
pc/no-pointer-types
branch
from
6784d8f
to
abc5e04
Compare
vtjnash
approved these changes
Jan 12, 2022
pchintalapudi
added
the
status:merge me
DilumAluthge
removed
the
status:merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Prem Chintalapudi <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Prem Chintalapudi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global pointer types are probably unnecessary, as LLVM provides convenience methods on the Type class to get pointers to integer and floating point types already. However, the global pointer types are persisted throughout codegen, so it's probably worth getting some compile time regressions before committing to just removing the global pointer types without an intermediate caching layer.
Depends on #43752 for integer type removal.