Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing colour :light_white #43744

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Add missing colour :light_white #43744

merged 1 commit into from
Jan 12, 2022

Conversation

eschnett
Copy link
Contributor

Julia currently defines 15 of the 16 "basic" ANSI colours, omitting "bright white" (see https://en.wikipedia.org/wiki/ANSI_escape_code). This adds "bright white", which Julia would call "light white".

Julia currently defines 15 of the 16 "basic" ANSI colours, omitting "bright white" (see https://en.wikipedia.org/wiki/ANSI_escape_code). This adds "bright white", which Julia would call "light white".
@oscardssmith oscardssmith added the domain:display and printing Aesthetics and correctness of printed representations of objects. label Jan 10, 2022
@eschnett
Copy link
Contributor Author

The doctests timed out.

@fredrikekre fredrikekre added the needs tests Unit tests are required for this change label Jan 10, 2022
@vtjnash vtjnash merged commit 2ed3ec4 into JuliaLang:master Jan 12, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
Julia currently defines 15 of the 16 "basic" ANSI colours, omitting "bright white" (see https://en.wikipedia.org/wiki/ANSI_escape_code). This adds "bright white", which Julia would call "light white".
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Julia currently defines 15 of the 16 "basic" ANSI colours, omitting "bright white" (see https://en.wikipedia.org/wiki/ANSI_escape_code). This adds "bright white", which Julia would call "light white".
@eschnett eschnett deleted the patch-7 branch August 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:display and printing Aesthetics and correctness of printed representations of objects. needs tests Unit tests are required for this change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants