Add some comments to Make.inc that explicitly define what we mean when we say "assert build of Julia"
#43732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen we say "assert build of Julia"
DilumAluthge
added
domain:docs
…"assert build" of Julia
|
@staticfloat I went ahead and added a few sentences to the devdocs about assert builds. Let me know if that looks okay, or if you'd prefer we just stick to the comments in |
vchuravy
approved these changes
Jan 11, 2022
doc/src/devdocs/build/build.md
Outdated
| ``` | ||
| git clone https://github.com/JuliaLang/julia.git | ||
| cd julia | ||
| make FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 |
There was a problem hiding this comment.
I normally recommend setting them in Make.user so that when you recompile you don't suddenly lose the assert nature.
There was a problem hiding this comment.
Good call. I'll make that change.
There was a problem hiding this comment.
Done! @vchuravy can you double check that the syntax is correct?
staticfloat
approved these changes
Jan 11, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…hen we say "assert build of Julia" (JuliaLang#43732) * Add some comments to `Make.inc` that explicitly define what we mean when we say "assert build of Julia" * Add a brief note to the devdocs with instructions on how to build an "assert build" of Julia * Recommend putting the variables into the `Make.user` file
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…hen we say "assert build of Julia" (JuliaLang#43732) * Add some comments to `Make.inc` that explicitly define what we mean when we say "assert build of Julia" * Add a brief note to the devdocs with instructions on how to build an "assert build" of Julia * Recommend putting the variables into the `Make.user` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figure we should explicitly write down the definition of "assert build of Julia". In this PR, I've done so in the form of comments in the
Make.incfile. If desired, I can also add a sentence or two somewhere in the devdocs.