Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup copy_oftype-like functions in factorizations #43700

Merged
merged 4 commits into from
Jan 14, 2022

Conversation

dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Jan 7, 2022

Minor cleanup after #40831.

I don't think we need non-mutating lu- and schur-methods with StridedMatrix type in their signature. copy(::StridedMatrix) does the same as copy_similar(::StridedMatrix), so that reduces the number of needed methods.

Closes JuliaDiff/TaylorSeries.jl#295

This now also closes #18970 in a much less verbose way than #41288.

@dkarrasch
Copy link
Member Author

@nanosoldier runtests(["TaylorSeries"], vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - no new issues were detected. A full report can be found here.

@dkarrasch dkarrasch added the domain:linear algebra Linear algebra label Jan 7, 2022
@dkarrasch
Copy link
Member Author

Pinging @daanhb @andreasnoack

@daanhb
Copy link
Contributor

daanhb commented Jan 7, 2022

This looks good to me. It is definitely good to reduce the number of the copy_X functions. For the issue with TaylorSeries, I think a problem might still remain if you supply a symmetric matrix with a different eltype (see my comment in #40831, I had replied there before seeing this)?

@dkarrasch
Copy link
Member Author

I picked up your proposal in the upcoming commit to this PR. I believe we will want get rid of copy_toarray (or, equivalently, Array{S}(A)), since packages that have their own array hierarchy, like CuArray, may want to obtain their own most generic array type, and not necessarily a plain Array.

@dkarrasch dkarrasch merged commit f15b4c3 into master Jan 14, 2022
@dkarrasch dkarrasch deleted the dk/copy_-_cleanup branch January 14, 2022 18:14
lbenet added a commit to JuliaDiff/TaylorSeries.jl that referenced this pull request Jan 14, 2022
lbenet added a commit to JuliaDiff/TaylorSeries.jl that referenced this pull request Jan 15, 2022
* Fix lu method

* Cleanup test

* Comment (ci.yml) continue-on-error for nightly

* Fix a problem introduced in mul!

* Revert signature of lu method

Works thanks to JuliaLang/julia#43700

* Add tests for inv of Symmetric{Taylor1{T}} matrices

* Bump patch version
N5N3 pushed a commit to N5N3/julia that referenced this pull request Jan 24, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants