ignore module_infer flag when generating a system image #43423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Jan 7, 2022
| @@ -903,7 +905,7 @@ function typeinf_ext(interp::AbstractInterpreter, mi::MethodInstance) | |||
| end | |||
| end | |||
| end | |||
| if ccall(:jl_get_module_infer, Cint, (Any,), method.module) == 0 | |||
| if ccall(:jl_get_module_infer, Cint, (Any,), method.module) == 0 && !generating_sysimg() | |||
| return retrieve_code_info(mi) | |||
There was a problem hiding this comment.
Aren't you holding a lock here? This seems like a bad place for this return to happen. (and also shouldn't it just return nothing, to directly signal that inference failed)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another precompilation improvement. The problem here is that skipping inference of, say, a JLL
__init__method is fine by itself, but at run time that can call another method which we then won't know about. So while we are generating a sysimg anyway, we might as well discover all the possibly-needed methods we can and just ignore the flag.