Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow CartesianIndex in isassigned #43394

Merged
merged 8 commits into from
May 12, 2022
Merged

allow CartesianIndex in isassigned #43394

merged 8 commits into from
May 12, 2022

Conversation

Moelf
Copy link
Sponsor Contributor

@Moelf Moelf commented Dec 11, 2021

close #43392

@N5N3
Copy link
Member

N5N3 commented Dec 11, 2021 •
edited
Loading

We'd better define these methods in multidimensional.jl.
BTW, why limit it to ::Array? We also has a try based fallback for AbstractArray.
Edit: It's good to allow mixing arguments. There seems no reason to not support isassigned(A, 1, CartesianIndex(1,1))

@Moelf
Copy link
Sponsor Contributor Author

Moelf commented Dec 15, 2021 •
edited
Loading

they can already do it via:

isassigned(A, CartesianIndex(1, CartesianIndex(1,1)))

but I guess I can put this in the PR

@Moelf
Copy link
Sponsor Contributor Author

Moelf commented Feb 8, 2022 •
edited
Loading

bump before 1.8 freeze (is this even a feature?)

N5N3
N5N3 reviewed Feb 9, 2022
View reviewed changes
base/multidimensional.jl Outdated Show resolved Hide resolved
N5N3
N5N3 reviewed Feb 11, 2022
View reviewed changes
base/multidimensional.jl Outdated Show resolved Hide resolved
@Moelf
Copy link
Sponsor Contributor Author

Moelf commented May 6, 2022 •
edited
Loading

gentle bump

@KristofferC KristofferC added merge me PR is reviewed. Merge when all tests are passing arrays [a, r, r, a, y, s] labels May 11, 2022
@KristofferC KristofferC merged commit c889fbc into JuliaLang:master May 12, 2022
@Moelf Moelf deleted the isassigned_cartesian branch May 12, 2022 13:55
@giordano giordano removed the merge me PR is reviewed. Merge when all tests are passing label May 13, 2022
@N5N3 N5N3 mentioned this pull request Jun 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N5N3 N5N3 N5N3 left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
arrays [a, r, r, a, y, s]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isassigned not defined for CartesianIndex arguments
5 participants
@Moelf @N5N3 @JeffBezanson @giordano @KristofferC