better errors for trailing_zeros and friends on BigInt #43240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. `trailing_zeros(big(0))` is not meaningful; the underlying `MPZ.scan1` returns `typemax(Culong)` to convey this. But we were converting to `Int`, which gave either `InexactError` (not user-friendly) or `typemax(UInt32)` on Windows, which was really meaningless. We now throw `DomainError` on all architectures.
rfourquet
added
domain:bignums
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
E.g. `trailing_zeros(big(0))` is not meaningful; the underlying `MPZ.scan1` returns `typemax(Culong)` to convey this. But we were converting to `Int`, which gave either `InexactError` (not user-friendly) or `typemax(UInt32)` on Windows, which was really meaningless. We now throw `DomainError` on all architectures.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
E.g. `trailing_zeros(big(0))` is not meaningful; the underlying `MPZ.scan1` returns `typemax(Culong)` to convey this. But we were converting to `Int`, which gave either `InexactError` (not user-friendly) or `typemax(UInt32)` on Windows, which was really meaningless. We now throw `DomainError` on all architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g.
trailing_zeros(big(0))is not meaningful; the underlyingMPZ.scan1returns
typemax(Culong)to convey this. But we were converting toInt,which gave either
InexactError(not user-friendly) ortypemax(UInt32)on Windows, which was really meaningless. We now throw
DomainErroron all architectures.