fix atomic fences #43093
Merged
fix atomic fences #43093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were disallowing the opposite of the orders that we intended to disallow.
KristofferC
pushed a commit
that referenced
this pull request
Nov 19, 2021
Previously, we were disallowing the opposite of the orders that we intended to disallow. (cherry picked from commit 28c49ce)
29 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 26, 2021
Previously, we were disallowing the opposite of the orders that we intended to disallow. (cherry picked from commit 28c49ce)
KristofferC
reviewed
Nov 26, 2021
| @@ -164,8 +164,17 @@ end | |||
| @test_intrinsic Core.Intrinsics.fptoui UInt Float16(3.3) UInt(3) | |||
| end | |||
|
|
|||
| @test Core.Intrinsics.atomic_fence(:sequentially_consistent) === nothing | |||
| using Base.Experimental: @force_compile | |||
There was a problem hiding this comment.
I had to remove this from 1.7 (since it doesn't have @force_compile). We'll see if the tests pass without it.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Previously, we were disallowing the opposite of the orders that we intended to disallow.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Previously, we were disallowing the opposite of the orders that we intended to disallow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were disallowing the opposite of the orders that we intended to disallow.