flisp: remove support for and need for reentrancy #43031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ; Log a syntax deprecation, attributing it to current-filename and the line | ||
| ; number of the stream `s` | ||
| (define (parser-depwarn s what instead) |
There was a problem hiding this comment.
Are we sure we won't want this again at some point?
There was a problem hiding this comment.
No more deprecations!
de0bde7
to
1615578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the only remaining case where we needed to be able to support calling back into flisp, creating a risk that we'd allocate as many flisp contexts as there are Tasks on the system. After this change, we should only need to allocate, at most,
nthreadscopies of flisp.