Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system versions of libwhich and libblastrampoline #43000

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

haampie
Copy link
Contributor

@haampie haampie commented Nov 8, 2021

Currently Julia can't build on air-gapped systems because libblastrampoline and libwhich sources are always downloaded.

This PR adds the missing USE_SYSTEM_{LIBWHICH,LIBBLASTRAMPOLINE} to fix that.

@DilumAluthge DilumAluthge added the domain:building Build system, or building Julia or its dependencies label Nov 8, 2021
Copy link
Sponsor Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, it looks like these are included in make -C deps get (e.g. via make full-source-dist) which should also stop them from being downloaded if USE_BINARYBUILDER is 0, right?

@vtjnash vtjnash merged commit ee4bcab into JuliaLang:master Nov 8, 2021
@haampie haampie deleted the fix/vendored-deps branch November 8, 2021 19:32
Make.inc Show resolved Hide resolved
yuyichao added a commit to archlinuxcn/repo that referenced this pull request Nov 9, 2021
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
daviehh pushed a commit to daviehh/julia that referenced this pull request Nov 16, 2021
haampie added a commit to haampie/julia that referenced this pull request Nov 24, 2021
haampie added a commit to haampie/julia that referenced this pull request Dec 6, 2021
haampie added a commit to haampie/julia that referenced this pull request Dec 6, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:building Build system, or building Julia or its dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants