Add missing type parameter to TakeWhile #42958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't say I really understand what difference it makes, but without this `TakeWhile` has `eltype` of `Any`
|
Probably a good idea to add a test as well. Seems like this was removed in #32427. |
vtjnash
added
the
status:merge me
KristofferC
added
backport 1.6
DilumAluthge
removed
the
status:merge me
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2021
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
66 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2021
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
95 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 10, 2021
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
KristofferC
pushed a commit
that referenced
this pull request
Nov 11, 2021
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
KristofferC
pushed a commit
that referenced
this pull request
Nov 12, 2021
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
KristofferC
removed
backport 1.6
daviehh
pushed a commit
to daviehh/julia
that referenced
this pull request
Nov 16, 2021
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Without this `TakeWhile` has `eltype` of `Any`
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Without this `TakeWhile` has `eltype` of `Any`
staticfloat
pushed a commit
that referenced
this pull request
Dec 23, 2022
Without this `TakeWhile` has `eltype` of `Any` (cherry picked from commit ab0c6dd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't say I really understand what difference it makes, but without this
TakeWhilehaseltypeofAny