Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend doc-string for @deprecate #42892

Merged
merged 8 commits into from
Feb 19, 2022
Merged

Conversation

thchr
Copy link
Contributor

@thchr thchr commented Nov 1, 2021

Following a discussion on Slack, I figured it might be nice to expand the the doc-string for @deprecate a bit.

cc. @fredrikekre who filled me in on the syntax options.

base/deprecated.jl Outdated Show resolved Hide resolved
base/deprecated.jl Outdated Show resolved Hide resolved
@fredrikekre fredrikekre added the domain:docs This change adds or pertains to documentation label Nov 1, 2021
@thchr
Copy link
Contributor Author

thchr commented Jan 19, 2022

Gentle bump.

@oscardssmith
Copy link
Member

@fredrikekre is this ready to merge?

@thchr
Copy link
Contributor Author

thchr commented Feb 15, 2022

Bump :)

@oscardssmith
Copy link
Member

Can you rebase this? For some reason github isn't letting me merge.

@oscardssmith
Copy link
Member

Sorry about the delay in merging this.

@thchr
Copy link
Contributor Author

thchr commented Feb 15, 2022

There aren't any merge-conflicts though, so a rebase shouldn't be strictly needed (or am I unaware of something?)?
I can rebase tomorrow though, no problem.

@oscardssmith
Copy link
Member

When I try to merge, I see
image
I've never seen it before, and I'm really confused.

base/deprecated.jl Outdated Show resolved Hide resolved
@thchr
Copy link
Contributor Author

thchr commented Feb 15, 2022

Rebased now (a merge conflict appeared from #44178 overnight).

@oscardssmith oscardssmith added the status:merge me PR is reviewed. Merge when all tests are passing label Feb 15, 2022
@DilumAluthge DilumAluthge merged commit f544321 into JuliaLang:master Feb 19, 2022
@DilumAluthge DilumAluthge removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 19, 2022
staticfloat pushed a commit to JuliaCI/julia-buildkite-testing that referenced this pull request Mar 2, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants