Test: make Error constructor more robust to broken objects #42850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| bt_str = "" | ||
| end | ||
| value = try # try the latest world for this, since we might have eval'd new code for show |
There was a problem hiding this comment.
Would we not need to do this above as well?
There was a problem hiding this comment.
That probably does make sense too. I wasn't sure at first which one was getting called in that case
vtjnash
commented
Oct 29, 2021
simeonschaub
approved these changes
Oct 29, 2021
vtjnash
added
the
status:merge me
DilumAluthge
removed
the
status:merge me
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes make incompletely defined objects for testing, such as declaring simply
struct AnInt <: Signed; end, but not defining the methods required by their API. If we have an error involving them, that then sometimes breaks the error reporting code, obscuring the real point of failure. This tries to be more robust against that case, so we still get information on what expression caused the failure to occur and it doesn't kill the rest of the testset.