handle some cases of null Task in segv handling #42836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure we do not use round-robin sampling when printing a critical error, only for profiling.
vtjnash
force-pushed
the
jn/segv-null-task
branch
from
34aecdb
to
36399c7
Compare
vtjnash
added
the
status:merge me
vchuravy
approved these changes
Oct 30, 2021
66 tasks
DilumAluthge
removed
the
status:merge me
|
Needs a manual backport for 1.7. |
vtjnash
added a commit
that referenced
this pull request
Nov 2, 2021
Also ensure we do not use round-robin sampling when printing a critical error, only for profiling. (cherry picked from commit ad607a2)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Also ensure we do not use round-robin sampling when printing a critical error, only for profiling.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Also ensure we do not use round-robin sampling when printing a critical error, only for profiling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this could be NULL in certain cases, which wasn't be handled previously. Also ensure we do not use round-robin sampling when printing a critical error, only for profiling.