InteractiveUtils: make code_llvm default atype work with no-arg functions
#42496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about |
`code_llvm` and `code_native` expects a single matching method, but the
default value of their argument `types=Tuple` doesn't match with any
function signature and so we actually can't use the default value.
This PR changes the default argument type to `Tuple{}`, so that
`code_llvm` and `code_native` work with no-arg functions by default,
e.g. now we can use them like:
```julia
code_llvm() do # previously, we need to call `code_llvm(()) do ... end`
sin(42)
end
```
One possible consideration is that now default `types` argument are
inconsistent between `code_lowered`/`code_typed` and `code_llvm`/`code_native`,
but I don't think it's confusing because in fact they work very differently,
i.e. they expect multiple vs. single matching methods, return result vs. print result.
aviatesk
force-pushed
the
avi/defaulttt
branch
from
edaa8ca
to
0f2d0e2
Compare
|
Sounds reasonable. What do you think on 0f2d0e2 ? |
|
@JeffBezanson can I move this forward ? |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
…functions with single method (JuliaLang#42496) `code_llvm` and `code_native` expects a single matching method, but the default value of `types=Tuple` argument doesn't match with any function signature and so we actually can't use that default value. With this PR, the default argument type will be computed by `default_tt`, which returns an appropriate signature if a function only has a single method, otherwise returns `Tuple` (which is the same default value as before). Now `code_llvm` and `code_native` by default work with functions that have a single method, e.g.: ```julia code_llvm() do # previously, we need to call `code_llvm(()) do ... end` sin(42) end ```
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
…functions with single method (JuliaLang#42496) `code_llvm` and `code_native` expects a single matching method, but the default value of `types=Tuple` argument doesn't match with any function signature and so we actually can't use that default value. With this PR, the default argument type will be computed by `default_tt`, which returns an appropriate signature if a function only has a single method, otherwise returns `Tuple` (which is the same default value as before). Now `code_llvm` and `code_native` by default work with functions that have a single method, e.g.: ```julia code_llvm() do # previously, we need to call `code_llvm(()) do ... end` sin(42) end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code_llvmandcode_nativeexpects a single matching method, but thedefault value of their argument
types=Tupledoesn't match with anyfunction signature and so we actually can't use the default value.
This PR changes the default argument type to
Tuple{}, so thatcode_llvmandcode_nativework with no-arg functions by default,e.g. now we can use them like:
One possible consideration is that now default
typesargument areinconsistent between
code_lowered/code_typedandcode_llvm/code_native,but I don't think it's confusing because in fact they work very differently,
i.e. they expect multiple vs. single matching methods, return result vs. print result.