Vagrant: update Vagrantfile, fix make testall #4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile libuv from source and use LLVM 3.3. Also, point the testall target at the executable in usr/bin instead of the symlink, which won't exist in the Vagrant build.
|
Anyone in particular that ought to review? I suppose @ViralBShah, @loladiro, @vtjnash and/or @staticfloat? |
|
LGTM |
|
I wish we could use 64 bit blas, but good otherwise. |
|
@ViralBShah That's because we're using the OpenBLAS off of the PPA to avoid having to build it from scratch. |
pao
added a commit
that referenced
this pull request
Sep 10, 2013
Vagrant: update Vagrantfile, fix make testall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile libuv from source and use LLVM 3.3. Also, point the testall target at the executable in usr/bin instead of the symlink, which won't exist in the Vagrant build.
Running this through a pull request due to the Make.inc change.
I think I was supposed to have this fixed a couple of weeks ago, so getting it taken care of finally.