improve the inferrability of isequal(::Any, ::Any)
#42195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Sep 10, 2021
vtjnash
reviewed
Sep 10, 2021
test/operators.jl
Outdated
| @@ -81,6 +81,14 @@ import Base.< | |||
| @test isequal(minmax(TO23094(2), TO23094(1))[1], TO23094(1)) | |||
| @test isequal(minmax(TO23094(2), TO23094(1))[2], TO23094(2)) | |||
|
|
|||
| let | |||
| m = Module() | |||
There was a problem hiding this comment.
don't make anonymous modules unless you must. they unnecessarily complicate the tests
There was a problem hiding this comment.
I prefer using it because it makes sure we can avoid name collision.
f42195(...) = ... as toplevel code would look better ?
vtjnash
reviewed
Sep 10, 2021
There was a problem hiding this comment.
seems like this test might fail is any new isequal method gets added
julia> methods(isequal, (Any,Int))
# 3 methods for generic function "isequal":
[1] isequal(x::AbstractFloat, y::Real) in Base at operators.jl:147
[2] isequal(::Missing, ::Any) in Base at missing.jl:81
[3] isequal(x, y) in Base at operators.jl:140
Currently, the return type of `isequal(::Any, ::Any)` is inferred as
`Union{Bool,Missing}` because it takes the possibilities of e.g.
`==(::Any, ::Missing)` into account.
But actually `isequal` already handles every `missing` case by dispatch:
<https://github.com/JuliaLang/julia/blob/2f00c5f6e2211ed1588976dbbe7b022148716d95/base/missing.jl#L80-L82>
, and thus we can improve the inferrability by type annotation.
aviatesk
force-pushed
the
avi/isequalinf
branch
from
e7d74fe
to
c4dd759
Compare
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Currently, the return type of `isequal(::Any, ::Any)` is inferred as
`Union{Bool,Missing}` because it takes the possibilities of e.g.
`==(::Any, ::Missing)` into account.
But actually `isequal` already handles every `missing` case by dispatch:
<https://github.com/JuliaLang/julia/blob/2f00c5f6e2211ed1588976dbbe7b022148716d95/base/missing.jl#L80-L82>
, and we can improve the inferrability by type annotation.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Currently, the return type of `isequal(::Any, ::Any)` is inferred as
`Union{Bool,Missing}` because it takes the possibilities of e.g.
`==(::Any, ::Missing)` into account.
But actually `isequal` already handles every `missing` case by dispatch:
<https://github.com/JuliaLang/julia/blob/2f00c5f6e2211ed1588976dbbe7b022148716d95/base/missing.jl#L80-L82>
, and we can improve the inferrability by type annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the return type of
isequal(::Any, ::Any)is inferred asUnion{Bool,Missing}because it takes the possibilities of e.g.==(::Any, ::Missing) -> Missinginto account.But actually
isequalalready handles everymissingcase by dispatch:julia/base/missing.jl
Lines 80 to 82 in 2f00c5f
, and thus we can improve the inferrability by type annotation.