Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ⊊, ⊋ on non-Set arguments #42155

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

cmcaine
Copy link
Contributor

@cmcaine cmcaine commented Sep 8, 2021

These have been broken since at least 84da967 (2018), but probably forever (I didn't follow the blame past the renaming of the file).

Here's an example of getting the wrong answer:

julia> issetequal((1, 2), (1, 2, 2)) # correct
true

julia> issubset((1, 2), (1, 2, 2)) # correct
true

julia> (1, 2)  (1, 2, 2) # incorrect
true

@cmcaine
Copy link
Contributor Author

cmcaine commented Sep 8, 2021

CI failure looks unrelated.

@JeffBezanson JeffBezanson added the collections Data structures holding multiple items, e.g. sets label Sep 9, 2021
@JeffBezanson JeffBezanson merged commit 655a1a4 into JuliaLang:master Sep 9, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collections Data structures holding multiple items, e.g. sets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants