Fix build failure from WITH_DTRACE on Darwin
#42146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building `WITH_DTRACE=1` off of master fails with syntax errors from
`uprobes.d` on macOS. I've added a modified `uprobes.d` that should work
on Darwin and amended `src/Makefile` to use the appropriate one
depending on the platform.
For reference, the error from building without this change is:
dtrace: failed to compile script /private/tmp/julia/src/uprobes.d: line 5: syntax error near "probe"
make[1]: *** [uprobes.h.gen] Error 1
|
It seems that on Linux, the file for darwin works as well.
So maybe we can get away with just one file? |
|
I suspected that might be the case, but had no convenient way of testing it. That works for me; will push that change shortly. |
The same file seems to work on Linux too.
|
Pushed the suggested change. |
|
Thanks! |
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
WITH_DTRACE=1off of master fails with syntax errors fromuprobes.don macOS. I've added a modifieduprobes.dthat should workon Darwin and amended
src/Makefileto use the appropriate onedepending on the platform.
For reference, the error from building without this change is:
I'm not super familiar with Julia's
Makefiles, so there might be a nicer way to do what I'm trying to do here. Happy to change this where needed.CC @vchuravy