Define promote_rule
for Diagonal
matrices
#42142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
promote_rule
definition forDiagonal
matrices using the promotion rule for the parent diagonal vectors. I've also added a methodDiagonal{T, V}(::Diagonal)
to carry out necessary conversions. This differs from the constructorDiagonal{T,V}(::AbstractVector)
, and I hope that the usage is clear from the context. Currently the conversion throws an error, so this is not a breaking change.This has two positives:
bugfix
Master
This PR
type-stability
Currently on master
The element types are not concrete, as promotion falls back to
typejoin
here.After this PR