Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM libunwind to 12.0.1 #41993

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Update LLVM libunwind to 12.0.1 #41993

merged 1 commit into from
Aug 25, 2021

Conversation

ararslan
Copy link
Member

Partially in service of #41955/#41943, though currently only used on macOS.

@ararslan ararslan added system:mac Affects only macOS external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels Aug 24, 2021
staticfloat
staticfloat approved these changes Aug 25, 2021
View reviewed changes
Copy link
Sponsor Member

@staticfloat staticfloat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the binary perspective, but I don't know what else might need to happen for Julia to actually work with LLVM 12. Tests look good though!

@ararslan
Copy link
Member Author

but I don't know what else might need to happen for Julia to actually work with LLVM 12

Julia is already using LLVM 12: https://github.com/JuliaLang/julia/blob/master/deps/Versions.make#L47

@vchuravy
Copy link
Sponsor Member

We don't have LLVM libunwind on the normal upgrade path so I forgot to include it when upgrading the rest.

@staticfloat staticfloat merged commit 6b5bc3b into master Aug 25, 2021
@staticfloat staticfloat deleted the aa/llvm-libunwind-12 branch August 25, 2021 15:07
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@ararslan @LilithHafner
Update LLVM libunwind to 12.0.1 (JuliaLang#41993)
0ebf417
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@ararslan @LilithHafner
Update LLVM libunwind to 12.0.1 (JuliaLang#41993)
606eee2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

@omus omus Awaiting requested review from omus

Assignees
No one assigned
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:mac Affects only macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ararslan @vchuravy @staticfloat