Only do NFD normalization for latex tab-completion if needed #41870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GunnarFarneback
commented
Aug 12, 2021
| # Decompose NFC-normalized identifier to match tab-completion | ||
| # input if the first search came up empty. | ||
| s = normalize(s, :NFD) | ||
| latex = symbol_latex(s) |
There was a problem hiding this comment.
Maybe this second lookup is not needed?
|
Any chance this could be considered for backporting? |
fredrikekre
added
backport 1.6
84 tasks
95 tasks
|
It may not be important, but the commits (not the issue) have zero (0) in "0nly", not "Only". I checked and you can't search for it on Github, and the difference isn't very obvious in some fonts... |
66 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR:
With this PR:
Fixes #39814.