@testset for: avoid calling finish twice when it errors
#41715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is a MWE:
```julia
julia> using Test
@testset "a" for i=1:2
@test i != 1
end
a: Test Failed at REPL[3]:3
Expression: i != 1
Evaluated: 1 != 1
Stacktrace:
[...]
Test Summary: | Fail Total
a | 1 1
Test Summary: | Fail Total
a | 1 1
ERROR: Some tests did not pass: 0 passed, 1 failed, 0 errored, 0 broken.
caused by: Some tests did not pass: 0 passed, 1 failed, 0 errored, 0 broken.
```
The `finish` function is called twice, and for a toplevel testset, this means
throwing an error. This manifests in the above example by printing twice
the result of the testset (with "Test Summary"), and by having
"Error: ... caused by: ..." with the same message.
vtjnash
approved these changes
Jul 28, 2021
rfourquet
commented
Jul 29, 2021
| @@ -1345,7 +1345,10 @@ function testset_forloop(args, testloop, source) | |||
| # they can be handled properly by `finally` lowering. | |||
| if !first_iteration | |||
| pop_testset() | |||
| finish_errored = true | |||
There was a problem hiding this comment.
Maybe
Suggested change
| finish_errored = true | |
| finish_threw = true |
is more precise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a MWE:
The
finishfunction is called twice, and for a toplevel testset, this meansthrowing an error. This manifests in the above example by printing twice
the result of the testset (with "Test Summary"), and by having
"Error: ... caused by: ..." with the same message.
I'm not sure whether this is a correct fix (and the two level of
tryblocks, together with the "first_iteration" trick are a bit complex for me), and I don't know how to write a test for it. But otherwise this can at least serve as a bug report.cc. @yuyichao who introduced some related changes in #18011.