Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #40048, stack overflows in type intersection #41687

Merged
merged 1 commit into from
Aug 3, 2021
Merged

fix #40048, stack overflows in type intersection #41687

merged 1 commit into from
Aug 3, 2021

Conversation

JeffBezanson
Copy link
Sponsor Member

I partially gave up here and just put in a limit, but hopefully that's better than erroring.

fixes #40048

@JeffBezanson JeffBezanson added domain:types and dispatch Types, subtyping and method dispatch kind:bugfix This change fixes an existing bug backport 1.7 labels Jul 23, 2021
@JeffBezanson
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@Sacha0
Copy link
Member

Sacha0 commented Jul 24, 2021

Thanks Jeff! I will give this alternative patch a whirl on our testing branch and report back :).

@JeffBezanson
Copy link
Sponsor Member Author

PkgEval looks ok.

@KristofferC KristofferC mentioned this pull request Jul 26, 2021
Merged
82 tasks
@palday
Copy link
Contributor

palday commented Jul 28, 2021

This fixes the issue in MixedModels. There are some unrelated test failures (catching some deprecation warnings instead of the intended ones), but we'll take care of those (JuliaStats/MixedModels.jl#547).

cc: @dmbates

@ararslan
Copy link
Member

ararslan commented Aug 2, 2021

Anything blocking merging this?

@DilumAluthge DilumAluthge merged commit ca0331f into master Aug 3, 2021
@DilumAluthge DilumAluthge deleted the jb/fix40048-2 branch August 3, 2021 17:14
ararslan pushed a commit that referenced this pull request Aug 3, 2021
@JeffBezanson @ararslan
fix #40048, stack overflows in type intersection (#41687)
b79e002 
(cherry picked from commit ca0331f)
@ararslan ararslan mentioned this pull request Aug 3, 2021
Merged
@Sacha0
Copy link
Member

Sacha0 commented Aug 3, 2021

Apologies, I forgot to report back! It looks like this patch addresses the issue in our test suite as well :).

ararslan added a commit that referenced this pull request Aug 3, 2021
@ararslan @JeffBezanson
fix #40048, stack overflows in type intersection (#41687) (#41772)
6f8e1d3 
(cherry picked from commit ca0331f)

Co-authored-by: Jeff Bezanson <[email protected]>
KristofferC pushed a commit that referenced this pull request Aug 4, 2021
@JeffBezanson @KristofferC
fix #40048, stack overflows in type intersection (#41687)
a9c007b 
(cherry picked from commit ca0331f)
@vtjnash
Copy link
Sponsor Member

vtjnash commented Aug 19, 2021

This PR fails on master (which uses slightly different assert/debug settings than PRs) for win32: see https://build.julialang.org/#/builders/9/builds/2169

@chrisbrahms chrisbrahms mentioned this pull request Sep 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:types and dispatch Types, subtyping and method dispatch kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type inference failing with a stack overflow on 1.7-DEV
8 participants
@JeffBezanson @nanosoldier @Sacha0 @palday @ararslan @vtjnash @KristofferC @DilumAluthge