Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printf %g/%G format fix for Inf/NaN #41650

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

Seelengrab
Copy link
Contributor

Fixes #41631

@Seelengrab
Copy link
Contributor Author

mkdir -p
mkdir: missing operand
Try 'mkdir --help' for more information.
make[1]: *** [/buildworker/worker/package_linuxppc64le/build/usr/manifest/csl] Error 123

Uuhh.. Not Printf related?

@KristofferC
Copy link
Sponsor Member

Not Printf related?

No :)

@Seelengrab
Copy link
Contributor Author

I'll get the champagne then, a build failure that's not caused by me missing something 😂

@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 20, 2021
@KristofferC KristofferC requested a review from quinnj July 20, 2021 08:34
@KristofferC KristofferC added the kind:bugfix This change fixes an existing bug label Jul 20, 2021
@Seelengrab
Copy link
Contributor Author

Seelengrab commented Jul 20, 2021

Seems like Distributed tests deadlocked on Freebsd, works as intended on other platforms.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit 4f28e6f into JuliaLang:master Aug 3, 2021
@KristofferC
Copy link
Sponsor Member

Please squash PRs like this :)

@quinnj
Copy link
Member

quinnj commented Aug 12, 2021

Oof, sorry. I still think we shouldn't allow merge commits and just do rebase or squash.

@StefanKarpinski
Copy link
Sponsor Member

Merge commits are appropriate sometimes. Core devs often make PRs that are a series of logically separate, staged commits, in which case a merge commit is the right thing to do. A rebase would be ok in those cases but the GitHub UI for rebase-merge sucks and makes it impossible to trace each commit back to the PR that it came from, so that's not ideal.

@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Sep 7, 2021
@Seelengrab Seelengrab deleted the printf-format-fix branch April 2, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@printf crashes with g/G format and non-finite numbers
4 participants