update common_symbols #41490
Merged
update common_symbols #41490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
force-pushed
the
jb/commonsyms
branch
from
0d8cc16
to
1523304
Compare
|
What is the logic behind the reordering? |
|
I think it is sorted by the count. |
|
Correct. Probably would be good to sort the list in the usual order though; I can add that. |
|
It's probably orthogonal, but would it be worth making it so we automatically use the best ordering without having to edit the file when the counts change? |
|
Yes that would be great, it's just a bit of a bother since we'd have to compute the counts and then re-encode each method body while saving a system image. |
KristofferC
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shaves about 400k off the system image.