Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenBLAS_jll] Bump to v0.3.13+6 #41322

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Conversation

giordano
Copy link
Contributor

This version backports a fix for a SIGILL error on some CPUs.

Should fix #39865. @sostock @maleadt would you be able to test this PR on the machines where you can reproduce the issue? CC: @ViralBShah

This version backports a fix for a `SIGILL` error on some CPUs.
@DilumAluthge
Copy link
Member

Should this be backported? If so, to what version(s)?

@giordano
Copy link
Contributor Author

#39865 has 1.7 milestone

@DilumAluthge DilumAluthge added this to the 1.7 milestone Jun 23, 2021
@sostock
Copy link
Contributor

sostock commented Jun 23, 2021

For me, this PR solves the problem.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue here too.

@ViralBShah
Copy link
Member

Should be backported to 1.6 too.

@DilumAluthge DilumAluthge added the backport 1.6 Change should be backported to release-1.6 label Jun 23, 2021
@giordano
Copy link
Contributor Author

giordano commented Jun 23, 2021

Should it? Do we have reports of this issue in Julia v1.6? Julia v1.6 has a different version of openblas, I'd be very wary of mixing binaries versions within a minor version of Julia

@DilumAluthge DilumAluthge removed the backport 1.6 Change should be backported to release-1.6 label Jun 23, 2021
@sostock
Copy link
Contributor

sostock commented Jun 23, 2021

I don’t think it should be backported to 1.6, the error doesn’t occur in 1.6.

@ViralBShah
Copy link
Member

ViralBShah commented Jun 23, 2021

Ok yes. in that case backport not needed for 1.6. I was thinking it had the same openblas version.

@ViralBShah ViralBShah merged commit ab567be into JuliaLang:master Jun 23, 2021
@giordano giordano deleted the mg/bump-openblas branch June 23, 2021 12:03
KristofferC pushed a commit that referenced this pull request Jun 26, 2021
* [OpenBLAS_jll] Bump to `v0.3.13+6`

This version backports a fix for a `SIGILL` error on some CPUs.

* [deps] Bundle backported OpenBLAS patches

(cherry picked from commit ab567be)
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
* [OpenBLAS_jll] Bump to `v0.3.13+6`

This version backports a fix for a `SIGILL` error on some CPUs.

* [deps] Bundle backported OpenBLAS patches
jessymilare pushed a commit to jessymilare/julia that referenced this pull request Sep 11, 2021
* [OpenBLAS_jll] Bump to `v0.3.13+6`

This version backports a fix for a `SIGILL` error on some CPUs.

* [deps] Bundle backported OpenBLAS patches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libopenblas: illegal instruction on master
6 participants