Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix preference loading for non string value #41294

Merged
merged 1 commit into from
Jun 21, 2021
Merged

fix preference loading for non string value #41294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix preference loading
  • Loading branch information
@Roger-luo
Roger-luo committed Jun 21, 2021
commit 0661d8466c859028295667e820e1a00caf9f715f
6 changes: 3 additions & 3 deletions base/loading.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1765,9 +1765,9 @@ function get_preferences_hash(uuid::Union{UUID, Nothing}, prefs_list::Vector{Str

# Walk through each name that's called out as a compile-time preference
for name in prefs_list
prefs_name = get(prefs, name, nothing)::Union{String, Nothing}
if prefs_name !== nothing
h = hash(prefs_name, h)
prefs_value = get(prefs, name, nothing)
if prefs_value !== nothing
h = hash(prefs_value, h)
end
end
# We always return a `UInt64` so that our serialization format is stable
Expand Down