make statement_costs! accept IRCode
#41257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to use this in Cthulhu, which uses `IRCode` for optimized code instead of `CodeInfo`.
aviatesk
approved these changes
Jun 18, 2021
simeonschaub
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Jun 23, 2021
This allows printing inlining costs alongside optimized IR similar to `Base.print_statement_costs`, which I found useful for debugging why some functions are not inlined. They are highlighted green, because I found them hard to distinguish otherwise, but I am open to suggestions regarding formatting. This relies on JuliaLang/julia#41257, which I hope can be backported to 1.7, so we don't have to worry about compatibility.
KristofferC
pushed a commit
that referenced
this pull request
Jun 26, 2021
I want to use this in Cthulhu, which uses `IRCode` for optimized code instead of `CodeInfo`. (cherry picked from commit 083272b)
51 tasks
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
I want to use this in Cthulhu, which uses `IRCode` for optimized code instead of `CodeInfo`.
aviatesk
added a commit
to JuliaDebug/Cthulhu.jl
that referenced
this pull request
Jul 22, 2021
* add option to print inlining costs This allows printing inlining costs alongside optimized IR similar to `Base.print_statement_costs`, which I found useful for debugging why some functions are not inlined. They are highlighted green, because I found them hard to distinguish otherwise, but I am open to suggestions regarding formatting. This relies on JuliaLang/julia#41257, which I hope can be backported to 1.7, so we don't have to worry about compatibility. * don't fix necessary typo * fix * passing on `inline_cost` config when descending * add warning message Co-authored-by: Shuhei Kadowaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use this in Cthulhu, which uses
IRCodefor optimized codeinstead of
CodeInfo.