Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow vectors in reflectorApply! #41234

Closed
wants to merge 3 commits into from
Closed

Allow vectors in reflectorApply! #41234

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
377a00a
Allow vectors in `reflectorApply!`
dlfivefifty Jun 15, 2021
7219aa7
Update stdlib/LinearAlgebra/src/generic.jl
dlfivefifty Jun 15, 2021
9a78a09
add tests
dkarrasch Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update stdlib/LinearAlgebra/src/generic.jl 
Co-authored-by: Daniel Karrasch <[email protected]>
  • Loading branch information
@dlfivefifty @dkarrasch
dlfivefifty and dkarrasch committed Jun 15, 2021
commit 7219aa7a58bf810c71bb79618aaf0644323e8ca0
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/generic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1517,7 +1517,7 @@ end
# apply reflector from left
@inline function reflectorApply!(x::AbstractVector, τ::Number, A::AbstractVecOrMat)
require_one_based_indexing(x)
m, n = size(A)
m, n = size(A, 1), size(A, 2)
if length(x) != m
throw(DimensionMismatch("reflector has length $(length(x)), which must match the first dimension of matrix A, $m"))
end
Expand Down